Prechádzať zdrojové kódy

don't save password in clear text in log

Roman Dmitriev 2 rokov pred
rodič
commit
8ac55f67c0
2 zmenil súbory, kde vykonal 7 pridanie a 3 odobranie
  1. 1 1
      html/admin/devices/editdevice.php
  2. 6 2
      html/inc/common.php

+ 1 - 1
html/admin/devices/editdevice.php

@@ -77,7 +77,7 @@ if (isset($_POST["editdevice"]) and isset($id)) {
     //access
     //access
     if (isset($_POST["f_login"])) { $new['login'] = $_POST["f_login"]; }
     if (isset($_POST["f_login"])) { $new['login'] = $_POST["f_login"]; }
     if (!empty($_POST["f_password"])) {
     if (!empty($_POST["f_password"])) {
-        if (!preg_match('/**/', $_POST["f_password"])) { 
+        if (!preg_match('/^\*+$/', $_POST["f_password"])) { 
             $new['password'] = crypt_string($_POST["f_password"]);  
             $new['password'] = crypt_string($_POST["f_password"]);  
             }
             }
         }
         }

+ 6 - 2
html/inc/common.php

@@ -3321,7 +3321,9 @@ function update_record($db, $table, $filter, $newvalue)
                 $network_changed = 1;
                 $network_changed = 1;
             }
             }
         }
         }
-        $changed_log = $changed_log . " $key => $value (old: $old[$key]),";
+        if (!preg_match('/password/i',$key)) {
+            $changed_log = $changed_log . " $key => $value (old: $old[$key]),";
+            }
         $run_sql = $run_sql . " `" . $key . "`='" . mysqli_real_escape_string($db, $value) . "',";
         $run_sql = $run_sql . " `" . $key . "`='" . mysqli_real_escape_string($db, $value) . "',";
     }
     }
     if (empty($run_sql)) {
     if (empty($run_sql)) {
@@ -3429,7 +3431,9 @@ function insert_record($db, $table, $newvalue)
         if (empty($value) and $value !== 0) {
         if (empty($value) and $value !== 0) {
             $value = '';
             $value = '';
         }
         }
-        $changed_log = $changed_log . " $key => $value,";
+        if (!preg_match('/password/i',$key)) {
+            $changed_log = $changed_log . " $key => $value,";
+            }
         $field_list = $field_list . "`" . $key . "`,";
         $field_list = $field_list . "`" . $key . "`,";
         $value = trim($value);
         $value = trim($value);
         $value_list = $value_list . "'" . mysqli_real_escape_string($db, $value) . "',";
         $value_list = $value_list . "'" . mysqli_real_escape_string($db, $value) . "',";